Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: release fix cr and test api #264

Merged
merged 8 commits into from
Sep 21, 2023
Merged

feat: release fix cr and test api #264

merged 8 commits into from
Sep 21, 2023

Conversation

Han-Ya-Jun
Copy link
Member

@Han-Ya-Jun Han-Ya-Jun commented Sep 19, 2023 •
edited
Loading

Description

  • 修复release相关api测试问题
  • 修改aip层发布历史统一为release_history
  • 去除批量发布逻辑，发布历史和stage一对一关联

Fixes # (issue)

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@Han-Ya-Jun Han-Ya-Jun requested review from wklken, zhu327 and alex-smile and removed request for wklken and zhu327 September 19, 2023 13:45
@wklken
Copy link
Collaborator

wklken commented Sep 20, 2023

  • ReleaseHistory有自己的status
  • is_running属于releaseHistory, 不属于event, event 本身是已经结束的

wklken
wklken reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@wklken wklken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wklken wklken merged commit 413f6c3 into TencentBlueKing:master Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wklken wklken wklken approved these changes

@alex-smile alex-smile alex-smile approved these changes

@zhu327 zhu327 Awaiting requested review from zhu327

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Han-Ya-Jun @wklken @alex-smile