Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify env cluster mock related testing code #1407

Merged
merged 2 commits into from
Jun 24, 2024
Merged

refactor: simplify env cluster mock related testing code #1407

merged 2 commits into from
Jun 24, 2024

Conversation

piglei
Copy link
Collaborator

@piglei piglei commented Jun 19, 2024

  • refactor: simplify env cluster mock related testing code, use the Cluster model instead of mocking.

@piglei piglei requested review from jamesgetx and narasux June 19, 2024 09:02
@piglei piglei force-pushed the refactor-mock-env-cluster branch from b704706 to f686b33 Compare June 24, 2024 02:28
@piglei piglei force-pushed the refactor-mock-env-cluster branch from f686b33 to 36d70a7 Compare June 24, 2024 02:40
@piglei piglei merged commit 48c9bae into TencentBlueKing:main Jun 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgetx jamesgetx jamesgetx approved these changes

@narasux narasux narasux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piglei @jamesgetx @narasux