Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support set custom domain ingress class separately #1462

Merged
merged 6 commits into from
Jul 11, 2024
Merged

feat: support set custom domain ingress class separately #1462

merged 6 commits into from
Jul 11, 2024

Conversation

jamesgetx
Copy link
Collaborator

@jamesgetx jamesgetx commented Jul 10, 2024 •
edited
Loading

  • 新增：支持为独立域名 ingress 设置 kubernetes.io/ingress.class
  • 修复：云原生独立域名配置 kubernetes.io/ingress.class 不生效的问题

@jamesgetx jamesgetx requested review from piglei and narasux July 10, 2024 03:47
piglei
piglei approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@piglei piglei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesgetx jamesgetx merged commit 96ee0ad into TencentBlueKing:main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narasux narasux narasux approved these changes

@piglei piglei piglei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgetx @piglei @narasux