fix: update_app_resource 函数添加 metadata 校验 #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgetx
approved these changes
Aug 22, 2024
SheepSheepChen
added a commit
to SheepSheepChen/blueking-paas
that referenced
this pull request
Aug 22, 2024
SheepSheepChen
added a commit
that referenced
this pull request
Aug 22, 2024
piglei
reviewed
Aug 29, 2024
| try: | ||
| # force replace metadata.name with app_code to avoid user modify | ||
| payload["metadata"]["name"] = generate_bkapp_name(module) | ||
| except KeyError as e: |
There was a problem hiding this comment.
准确来说上面的 payload["metadata"]["name"] 除了 KeyError 之外也可能跑出 TypeError，当 metadata 存在但是类型不是字典时。可以考虑拆分校验和赋值。
songzxc789
pushed a commit
to songzxc789/blueking-paas
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.