feat: support custom metric for cloud native app #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
apiserver/paasng/paasng/platform/modules/migrations/0016_auto_20240904_1439.py
Show resolved
Hide resolved
narasux
reviewed
Sep 5, 2024
apiserver/paasng/paasng/platform/engine/deploy/release/operator.py
Outdated
Show resolved
Hide resolved
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
narasux
reviewed
Sep 5, 2024
apiserver/paasng/paasng/platform/bkapp_model/migrations/0015_auto_20240904_1439.py
Outdated
Show resolved
Hide resolved
narasux
reviewed
Sep 5, 2024
apiserver/paasng/paasng/misc/monitoring/monitor/service_monitor/controller.py
Show resolved
Hide resolved
narasux
reviewed
Sep 5, 2024
apiserver/paasng/paas_wl/workloads/networking/ingress/kres_slzs/service.py
Show resolved
Hide resolved
jiayuan929
reviewed
Sep 5, 2024
apiserver/paasng/paasng/misc/monitoring/monitor/service_monitor/controller.py
Outdated
Show resolved
Hide resolved
piglei
reviewed
Sep 6, 2024
apiserver/paasng/paasng/platform/bkapp_model/serializers/serializers.py
Outdated
Show resolved
Hide resolved
apiserver/paasng/paasng/platform/bkapp_model/serializers/v1alpha2.py
Outdated
Show resolved
Hide resolved
apiserver/paasng/tests/paasng/misc/monitoring/service_monitor/test_controller.py
Show resolved
Hide resolved
|
|
||
| // 为蓝鲸监控采集注入对应的 label | ||
| if appInfo, err := applications.GetBkAppInfo(bkapp); err == nil { | ||
| labels["monitoring.bk.tencent.com/bk_app_code"] = appInfo.AppCode |
There was a problem hiding this comment.
这些 labels 有使用 - 替代 _ 的说法吗？其他项目大多用连字符
There was a problem hiding this comment.
从旧代码的注释来看，这些应该先前和蓝鲸监控侧约定好的 label，所以先继续沿用
piglei
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.