test: sync replicas in ModuleProcessSpecManager.sync_from_desc #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piglei
reviewed
Oct 29, 2024
| [ProcessTmpl(name=proc_name, command="foo", replicas=replicas)] | ||
| ) | ||
| spec = ModuleProcessSpec.objects.get(name=proc_name, module=bk_module) | ||
| assert spec.target_replicas == replicas or PROC_DEFAULT_REPLICAS |
There was a problem hiding this comment.
这个 .target_replicas 实际上还有意义吗，感觉对比了下面 get 两个环境的 replicas 就够了？这里有一个 or PROC_DEFAULT_REPLICAS 的逻辑会很奇怪，有点过于深入实现逻辑。
There was a problem hiding this comment.
确实这里的写法深入了实现逻辑，不符合测试的原则。已去除 target_replicas，单独验证 stag 和 prod 即可
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
单测：测试 ModuleProcessSpecManager.sync_from_desc 方法中，同步副本数的逻辑