fix: always reset overlay data when the base value was set on the process obj #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
piglei
commented
Nov 21, 2024
piglei
commented
- fix: always reset overlay data when the base value was set on the process obj
jamesgetx
reviewed
Nov 21, 2024
apiserver/paasng/paasng/platform/bkapp_model/entities_syncer/proc_env_overlays.py
Show resolved
Hide resolved
jamesgetx
reviewed
Nov 21, 2024
apiserver/paasng/paasng/platform/bkapp_model/entities_syncer/proc_env_overlays.py
Show resolved
Hide resolved
jamesgetx
approved these changes
Nov 21, 2024
jamesgetx
reviewed
Nov 21, 2024
| @@ -31,27 +31,48 @@ | |||
|
|
|||
|
|
|||
| def sync_env_overlays_replicas( | |||
There was a problem hiding this comment.
现在的特殊处理策略分散在了 sync_xxx 逻辑中。可以考虑在sync 之前预处理 bk app 模型(比如补全一些 env overlay配置)，这样 sync 逻辑职责比较单一，同步规则稳定
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.