Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dev_sandbox support spec version:3 app_desc.yaml #1798

Merged
merged 7 commits into from
Dec 19, 2024
Merged

feat: dev_sandbox support spec version:3 app_desc.yaml #1798

merged 7 commits into from
Dec 19, 2024

Conversation

SheepSheepChen
Copy link
Collaborator

No description provided.

narasux
narasux reviewed Dec 14, 2024
View reviewed changes
cnb-builder-shim/pkg/appdesc/desc.go Outdated
type Process struct {
var appSpecVersion2 = "2"
var appSpecVersion3 = "3"
var moduleName = utils.EnvOrDefault("BKPAAS_APP_MODULE_NAME", "")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

环境变量不适合到处读，得区分具体的使用用途，通过参数的方式传递

jamesgetx
jamesgetx reviewed Dec 16, 2024
View reviewed changes
cnb-builder-shim/pkg/appdesc/desc.go Outdated Show resolved Hide resolved
cnb-builder-shim/pkg/appdesc/desc.go Outdated Show resolved Hide resolved
cnb-builder-shim/pkg/appdesc/desc.go Outdated Show resolved Hide resolved
@narasux narasux merged commit c7afda6 into TencentBlueKing:builder-stack Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narasux narasux narasux approved these changes

@jamesgetx jamesgetx Awaiting requested review from jamesgetx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SheepSheepChen @jamesgetx @narasux