Raise alerts for volume/brick status change. #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r0h4n @nthomas-redhat Please review |
|
Have addressed all the comments in #287 here |
This patch sends alerts when the status of volume/bricks changes. Both from healthy to unhealthy and vice versa tendrl-bug-id: Tendrl#286 Signed-off-by: nnDarshan <darshan.n.2024@gmail.com>
r0h4n
approved these changes
Jun 7, 2017
| alert['time_stamp'] = tendrl_now().isoformat() | ||
| alert['alert_type'] = 'status' | ||
| severity = "info" | ||
| if curr_value == "Stopped": |
There was a problem hiding this comment.
please use lower case for string comparison
r0h4n
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sends alerts when the status of volume/bricks
changes. Both from healthy to unhealthy and vice versa
tendrl-bug-id: #286
Signed-off-by: nnDarshan darshan.n.2024@gmail.com