Added post checks to check if object are available in etcd post create #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r0h4n @nnDarshan plz review |
r0h4n
suggested changes
Jun 15, 2017
| retry_count = 0 | ||
| while True: | ||
| try: | ||
| volumes = NS._int.client.read( |
There was a problem hiding this comment.
use object.load() , we need to ensure all attributes inside the object are also present as provided by user
Because a Volume is only really fully available when you can load() it
Also, just load the actual volume instead of iterating over every volume
There was a problem hiding this comment.
As discussed earlier, while volume creation we have volume name only available. This post run atom is for create volume flow. To load a specific volume we need volume uuid which is not available here.
| @@ -0,0 +1,52 @@ | |||
| import etcd | |||
| import gevent | |||
| import subprocess | |||
| return True | ||
|
|
||
| retry_count += 1 | ||
| gevent.sleep(1) |
There was a problem hiding this comment.
Increase the timeout to 10 mins, we are going to allow configurable sds/node sync intervals in near future
tendrl-bug-id: Tendrl#296 Signed-off-by: Shubhendu <shtripat@redhat.com>
shtripat
force-pushed
the
check-object-available
branch
from
62b55dd
to
ae10fc8
Compare
r0h4n
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tendrl-bug-id: #296
Signed-off-by: Shubhendu shtripat@redhat.com