Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique machine id precheck not required #71

Closed
r0h4n opened this issue Feb 2, 2018 · 2 comments
Closed

Unique machine id precheck not required #71

r0h4n opened this issue Feb 2, 2018 · 2 comments
Assignees
@TimothyAsir

Comments

@r0h4n
Copy link
Contributor

r0h4n commented Feb 2, 2018

tendrl-node-agents have long stopped requiring an unique machine id

Is there any other reason for this check to exist?

https://github.com/Tendrl/tendrl-ansible/blob/master/prechecks.yml#L85
@mbukatov
Copy link
Collaborator

We can remove this check if machine id is no longer used. The check was implemented based on TEN-257.

That said, search for machine id shows me few results, so we may also need to remove it elsewhere.

TimothyAsirJeyasing added a commit to TimothyAsirJeyasing/tendrl-ansible that referenced this issue Feb 25, 2018
@TimothyAsirJeyasing
Remove machine-id check
b611c91 
tendrl-bug-id: Tendrl#71
Signed-off-by: Timothy Asir J <tjeyasin@redhat.com>
@TimothyAsirJeyasing TimothyAsirJeyasing mentioned this issue Feb 25, 2018
Merged
mbukatov pushed a commit to TimothyAsirJeyasing/tendrl-ansible that referenced this issue Feb 26, 2018
@TimothyAsirJeyasing @mbukatov
Remove machine-id check
f1527fb 
tendrl-bug-id: Tendrl#71
Signed-off-by: Timothy Asir J <tjeyasin@redhat.com>
@mbukatov
Copy link
Collaborator

Resolved by #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimothyAsir TimothyAsir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@r0h4n @TimothyAsir @mbukatov