Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified grafana dashboard to relative path from static path #1074

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

GowthamShanmugam
Copy link
Contributor

bugzilla: 1590416
tendrl-bug-id: #1073

Signed-off-by: GowthamShanmugam gshanmug@redhat.com

bugzilla: 1590416
tendrl-bug-id: Tendrl#1073

Signed-off-by: GowthamShanmugam <gshanmug@redhat.com>
@GowthamShanmugam GowthamShanmugam requested review from a team as code owners October 1, 2018 08:21
@GowthamShanmugam
Copy link
Contributor Author

@gnehapk @shirshendu @shtripat please review

Copy link
Member

@gnehapk gnehapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnehapk
Copy link
Member

gnehapk commented Oct 1, 2018

@GowthamShanmugam Please make sure that this PR should be merged only when the api changes are in.

@gnehapk
Copy link
Member

gnehapk commented Oct 16, 2018

@GowthamShanmugam are the API changes merged for this PR?

@GowthamShanmugam
Copy link
Contributor Author

@gnehapk no, it is still under review

@gnehapk gnehapk merged commit 3145736 into Tendrl:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants