Skip to content

feat: refactored tracker db folder structure. added alembic migrations #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

MiNeves00
Copy link
Collaborator

@MiNeves00 MiNeves00 commented May 5, 2025

LLMstudio Version X.X.X

What was done in this PR:

  • Large Refactor of llmstudio_tracker/db file organization into folders per type instead of per table.
  • Added alembic migrations for schema migrations
  • Added integration test for checking that writing to tracker db is working

How it was tested:

  • Integration & Unit Tests
  • Tested migrations for sqlite & postgres DB

Additional notes:

  • added alembic as a dependency

@MiNeves00 MiNeves00 requested a review from diogoncalves May 5, 2025 11:17
@MiNeves00 MiNeves00 removed the request for review from diogoncalves May 5, 2025 12:52
@MiNeves00 MiNeves00 marked this pull request as ready for review May 5, 2025 12:53
@MiNeves00 MiNeves00 marked this pull request as draft May 5, 2025 12:53
@MiNeves00 MiNeves00 requested a review from diogoncalves May 5, 2025 16:49
@MiNeves00 MiNeves00 marked this pull request as ready for review May 5, 2025 16:49
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change the name of the script to be more generic or move the "tests" of tracker to it's own script?

Review the generated migration file and adjust if needed.


## 4. Applying Migrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't applying the migrations be automatic whenever the clients starts the tracker server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants