Fix/conformer demo #204
Merged
Fix/conformer demo #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Transducer.recognize_beam()` expects dictionary of input tensors containing `"input_length"`, therefore `inputs["input_length"]` should have been computed before calling this method. Calling `math_util.get_reduced_length(inputs["inputs_length"], ...)` reduces `input_length` again and causes recognition on short audio segment. Another solution would be replacing `math_util.get_reduced_length(inputs["inputs_length"], ...)` with `math_util.get_reduced_length(inputs["inputs"].shape[1], ...)`, but as explained above it is already computed.
nglehuy
reviewed
May 28, 2021
ebraraktas
force-pushed
the
fix/conformer-demo
branch
from
309b3d4 to
5186643
Compare
ebraraktas
force-pushed
the
fix/conformer-demo
branch
from
5186643 to
9134eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conformer demo fails for beam search. This fixes bug in
Transformer.recognize_beam()andexamples/demonstration/conformer.pyscript.