Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Deployment Docs out of date #576

Closed
JoshSchoen opened this issue May 8, 2017 · 0 comments · Fixed by #1196
Closed

GitHub Deployment Docs out of date #576

JoshSchoen opened this issue May 8, 2017 · 0 comments · Fixed by #1196
Assignees
Labels
Milestone

Comments

@JoshSchoen
Copy link
Contributor

Feature Request

GitHub pages deployment documentation is out of date, it seems as though Angular CLI removed it.
angular/angular-cli#4385

What is the motivation / use case for changing the behavior?

Update deployment docs to show the correct deployment process for GitHub pages
https://teradata.github.io/covalent/#/docs/deployment

Other information

The workaround I found was to use this https://github.com/angular-buch/angular-cli-ghpages works well and is referenced in the CLI PR. The one thing I found that was not that obvious, I needed to add "pages" to the --base-href of the target branch. It also publishes remotely from the current local branch to be careful there.

  • ng build --prod --base-href "pages" builds dist folder like normal but sets the base-href to pages
  • angular-cli-ghpages publishes the dist folder to the gh-pages branch which I use for demo purposes.

Let me know if you need further information.

@emoralesb05 emoralesb05 added this to the Release Candidate 0 milestone Oct 11, 2017
@ilsiepotamus ilsiepotamus self-assigned this Oct 12, 2017
@emoralesb05 emoralesb05 modified the milestones: Release Candidate 3, Next Release Jan 19, 2018
@emoralesb05 emoralesb05 modified the milestones: Release Candidate 4, Next Release Jan 26, 2018
@emoralesb05 emoralesb05 removed this from the Next Release milestone Feb 7, 2018
@jeremysmartt jeremysmartt added this to the Release 2.0.0 milestone Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants