Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): GitHub Deployment Docs out of date #1196

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

jeremysmartt
Copy link
Collaborator

Description

Removed section in docs about using ng github-pages:deploy
closes #576

What's included?

  • Updated documentation

Test Steps

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:lib still works.
Screenshots or link to StackBlitz/Plunker

screen shot 2018-07-13 at 4 06 32 pm

@emoralesb05 emoralesb05 merged commit 61686f2 into develop Jul 15, 2018
@emoralesb05 emoralesb05 deleted the fix/github-deploy-576 branch July 15, 2018 22:29
@jeremysmartt jeremysmartt added this to the Release 2.0.0 milestone Jul 16, 2018
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Deployment Docs out of date
2 participants