feat(): upgrade to angular@latest+rc #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremysmartt
requested changes
Dec 18, 2019
scripts/ci/travis-script.sh
Outdated
| @@ -38,7 +38,7 @@ elif [ "${MODE}" = "release" ]; then | |||
| elif [ "${MODE}" = "unit-test" ]; then | |||
| npm run test | |||
| elif [ "${MODE}" = "audit" ]; then | |||
| npm audit | |||
| npm audit --only=prod --audit-level=high | |||
There was a problem hiding this comment.
Can we also add the --production flag? I believe this will make it so it ignores devDependencies, based on this:
npm/cli#202
emoralesb05
force-pushed
the
feat/upgrade-ng
branch
from
7d2a7ad
to
ea37cf7
Compare
jeremysmartt
approved these changes
Dec 18, 2019
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
* feat(): upgrade to angular@latest+rc * fix(): npm audit restriction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to latest 9+RC.
Test Steps
npm cinpm run serveGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:libstill works.