-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(material): Upgrade to latest material. (closes #346) #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `ESC` closing the sidenav on `side` mode
…selectable rows more efficiently.
This was referenced Feb 22, 2017
- fix bottom right position
…nt into feature/upgrade-material
kyleledbetter
approved these changes
Feb 22, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lotta work here, LGTM
ilsiepotamus
approved these changes
Feb 22, 2017
emoralesb05
changed the title
feature(material): Upgrade to latest material.
feature(material): Upgrade to latest material. (closes #346)
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to latest
@angular/material@2.0.0-beta.2
. https://github.com/angular/material2/blob/master/CHANGELOG.md#200-beta2-flannel-papaya-2017-02-15What's included?
Material Changes:
material
wheremd-input
has been removed as component and directive in favor of themdInput
directive selector.md-menu
[overlapTrigger]="false"
in notifications demo so the menu doesnt overlap theicon
(change)
event frommd-select
.Covalent Changes/Fixes because of
material
:refresh
work around fortooltips
used underOnPush
angular/components@632b964disableClose
input from sidenav to preventESC
closing the sidenav onside
mode. angular/components@52ade97number
type input works again.md-pseudo-checkbox
to render the selectable rows more efficiently. angular/components@3b6cab0Test Steps
npm run reinstall
ng serve
General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.NOTE: Needs heavy testing on all fronts since the
.mat
prefix change affected how certain rules are applied.