Decimal data type impementation #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecialize(...) function Adding bindLiteralParameters(...) method and 'parameterTypes' argument to specialize(...) function allows to bind literal parameters during function specialization. This allows to compute derivate variables that are partially applied to specialized function implementation.
SqlScalarFunctionBuilder can be used to define scalar function with multiple specialization methods. Specialization method will be selected based on concrete java type parameters, return type and optionally predicate. It is also possible to define extra parameters that will be passed to specialization method.
For datatypes with multiple binary representations we need to define same function multiple times depending on actal types of parameters. E.g. add (Slice a, Slice b) and add (long a, long b) represent + operator for DECIMAL type. First version for longer DECIMAL values (represented internally as Slice) and second, faster version for shorter decimals (represented internally as long). This patch allows multiple versions of same scalar udf/operator to be defined using annotation syntax. Functions with same name are grouped together and exposed as single ParametricFunction which internally does dispatching to proper MethodHandle based on actual parameter types at runtime.
Operators implemented: - add - subtract - multiply - divide - modulus - negation
Additionally support for unbounded base 128 varints stream was added since decimal column decoding requires it.
losipiuk
changed the title
losipiuk
changed the title
|
This PR follows #88 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another approach for decimal datatype implementation. It is based on varchar(x) PR (#88).