Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduced an arrow shooting tower #32

Merged
merged 5 commits into from
Aug 28, 2017
Merged

Conversation

0shine0
Copy link
Collaborator

@0shine0 0shine0 commented Aug 6, 2017

It is the blue slab type block in the inventory.
Just place is as you would a normal block.
To get more from console type : "give arrowTower"

@portokaliu
Copy link
Contributor

Instead of adding all the events for starting and stopping the animations, wouldn't it be easier to make the turret rely on the behavior tree for that? It seems to be exactly what the turrent would need.

@0shine0
Copy link
Collaborator Author

0shine0 commented Aug 9, 2017

@portokaliu sorry, but i have little knowledge on behaviour trees. I did not yet use it in towers, yeah but they are supposed to be used in turrets. Will read about behaviour trees and how they work

@portokaliu
Copy link
Contributor

@0shine0 you can look at https://github.com/Terasology/Behaviors/wiki for that purpose or bug dkambersky in the ai channel on slack. He explained fairly well as well

@ForceBlockActive
public class EntitiesConnectorComponent implements Component{
public List<ConnectingInfo> childEntities = Lists.newArrayList();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would this be different from what the LocationComponent ?

// @Replicate
// public Quat4f angularAccel = new Quat4f(0, 0, 0, 1);
// @Replicate
// public Quat4f angularForce = new Quat4f(0, 0, 0, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the commented lines ever going to be needed?
If yes, you should rename the stuff, like LinearForce and AngularForce (which can just be named Torque)
Force is pretty much acceleration x mass. If there is no other difference I don't see why the differentiation would be needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented lines may be needed for rotational purposes. Yeah, i will name it as torque. I introduced Force so that a constant force could be applied entities with different masses so that their accel will differ for same force

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But does acceleration still need to exist if you already use the force + mass combo? I see it as either use one or the other, but you may have other plans, so I'd wanna hear them :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly use them for gravitational accel, as well for force field accelerations in the future, where the acceleration will be constant for each entity irrespective of mass. I guess we can bypass accel by implementing that in force itself, never gave much thought about implementation. I will optimize the whole module rigorously after gsoc is over.

if(sniperScope.scoped){
nuiManager.getHUD().addHUDElement("scopeHud");
}
else{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small code formatting issue: this should look like:

} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't checkstyle flag it up?

@0shine0 0shine0 merged commit 424e269 into Terasology:develop Aug 28, 2017
@0shine0 0shine0 deleted the shine2 branch January 16, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants