chore: small code and doc improvements #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added
Category: Doc
2 tasks
naalit
approved these changes
Aug 15, 2021
| templateNames.stream() | ||
| .map(resolver) | ||
| .filter(Optional::isPresent) | ||
| .map(Optional::get) |
There was a problem hiding this comment.
I wish we were using Java 9 so instead of .filter().map() it could be
templateNames.stream()
.map(resolver)
.flatMap(Optional::stream)I learned there's actually Streams::stream for that purpose in Guava, but that's marked beta and this isn't actually a big deal.
There was a problem hiding this comment.
Yeah, I know 🙈 Should probably add a comment here marking this as a potential Java 9+ improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments and code improvements done while adding new building templates to Metal Reneges. I thought those explanations might be helpful to have in place, as well as some code improvements to make the work with
Optionals a bit more idiomatic here.