Make oreon attributes affect task completion time #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naman-sopho
requested changes
Aug 12, 2019
| float currentTime = timer.getGameTime(); | ||
|
|
||
| return currentTime + newTask.taskDuration; | ||
| return currentTime + newTask.taskDuration - Math.min(relevantSkill / 2, newTask.taskDuration); |
There was a problem hiding this comment.
We should come up with a better formula. In some cases this might just return the currentTime as task completion time which does not seem right.
| @@ -33,6 +33,8 @@ public TrainIntelligenceTask() { | |||
| this.strength = STRENGTH; | |||
| this.hunger = HUNGER; | |||
|
|
|||
| this.primaryAttr = STRENGTH_ATTR; | |||
There was a problem hiding this comment.
This should be INTELLIGENCE_ATTR
| @@ -33,6 +33,8 @@ public TrainStrengthTask() { | |||
| this.strength = STRENGTH; | |||
| this.hunger = HUNGER; | |||
|
|
|||
| this.primaryAttr = INTELLIGENCE_ATTR; | |||
There was a problem hiding this comment.
This should be STRENGTH_ATTR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Recommended testing: spawn two oreons and note their strength values (strength is the primary skill for building). After they are both spawned, quickly start two buildings of the same type. The oreon with the higher strength value will finish its task first.