Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: binary SSTable format #68

Merged
merged 46 commits into from
Aug 3, 2021
Merged

feat!: binary SSTable format #68

merged 46 commits into from
Aug 3, 2021

Conversation

Terkwood
Copy link
Owner

@Terkwood Terkwood commented Aug 1, 2021 •
edited
Loading

Resolves #51. Resolves #60.

Tasks

@Terkwood Terkwood added the enhancement New feature or request label Aug 1, 2021
@Terkwood
Copy link
Owner Author

Terkwood commented Aug 1, 2021

AugustDB/lib/august_db/compaction.ex

Line 90 in 7416a33

{:ok, f} = :file.open(p, [:read, :binary, {:read_ahead, 100_000}])

@Terkwood
Copy link
Owner Author

Terkwood commented Aug 1, 2021

https://erlang.org/doc/man/file.html#read-2

Terkwood
Terkwood commented Aug 1, 2021
View reviewed changes
lib/august_db/sstable.ex Outdated Show resolved Hide resolved
@Terkwood
Copy link
Owner Author

Terkwood commented Aug 1, 2021

https://blog.tentamen.eu/how-to-pattern-match-bitstrings-and-binaries-in-elixir/

@Terkwood Terkwood marked this pull request as ready for review August 3, 2021 15:13
@Terkwood Terkwood merged commit 8f1f8aa into main Aug 3, 2021
@Terkwood Terkwood deleted the feat/binary-sstable-format branch August 3, 2021 15:41
@Terkwood
Copy link
Owner Author

Terkwood commented Aug 4, 2021

binary-sst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Macro.unescape from value_view.ex Binary SSTables
1 participant
@Terkwood