Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump server to 1.10.0 #119

Merged
merged 3 commits into from
Aug 21, 2023
Merged

chore: bump server to 1.10.0 #119

merged 3 commits into from
Aug 21, 2023

Conversation

jfcherng
Copy link
Collaborator

@jfcherng jfcherng commented Aug 19, 2023

This PR doesn't work by simply updating the server. I got

:: [05:53:05.974] <-  LSP-copilot LogMessage: {'message': '[DEBUG] [getCompletions] [2023-08-19T21:53:05.968Z] Producing empty completions due to document version mismatch. Completions requested for document version 0 but document version was 34.', 'level': 0, 'extra': ['Producing empty completions due to document version mismatch. Completions requested for document version 0 but document version was 34.'], 'metadataStr': '[DEBUG] [getCompletions] [2023-08-19T21:53:05.968Z]'}
:: [05:53:05.974] <<< LSP-copilot (49) (duration: 8ms): {'cancellationReason': 'DocumentVersionMismatch', 'completions': []}

in LSP's log panel.


Also, there is a new notification type.

:: [05:55:55.381] <?  LSP-copilot featureFlagsNotification: {'ssc': False, 'chat': True, 'rt': False}

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@jfcherng jfcherng marked this pull request as draft August 19, 2023 21:54
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@TerminalFi
Copy link
Owner

Guess we need to finally handle doc. Versions

@TerminalFi
Copy link
Owner

@jfcherng We can update utils.py:198 with "version": view.change_count() for now. Which is what LSP uses as the version. Copilot accepts this as well

Thanks to @TerminalFi.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@jfcherng jfcherng marked this pull request as ready for review August 21, 2023 03:20
@jfcherng
Copy link
Collaborator Author

Tested PR is working on my Win64 PC.

@jfcherng jfcherng merged commit effe764 into master Aug 21, 2023
2 checks passed
@jfcherng jfcherng deleted the chore/update-server branch August 21, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants