Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sign out command doesn't work #157

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: sign out command doesn't work #157

merged 1 commit into from
May 29, 2024

Conversation

jfcherng
Copy link
Collaborator

Fixes #156

@jfcherng jfcherng force-pushed the fix/sign-out branch 4 times, most recently from e4b54a7 to e18a08f Compare May 29, 2024 06:52
@jfcherng jfcherng changed the title fix: unauthorized account failed to sign out fix: sign out command doesn't work May 29, 2024
@TerminalFi
Copy link
Owner

Before merging, I'd like to look into this a bit.

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@TerminalFi
Copy link
Owner

@jfcherng This is odd, but the command works for me on MacOS?

@jfcherng
Copy link
Collaborator Author

jfcherng commented May 29, 2024

@jfcherng This is odd, but the command works for me on MacOS?

Even after re-sign in, can you sign out again?

@jfcherng
Copy link
Collaborator Author

jfcherng commented May 29, 2024

Some observations,

  • previously, copilot's session file is hosts.json but now (since when?) it's apps.json.
  • my first sign out success (I believe at that moment it uses hosts.json)
  • I re-sign in. After that, I failed to sign out. (now it uses apps.json)

I don't know whether the session file change matters or not.

@TerminalFi
Copy link
Owner

Mine just switched over to apps.json and now signout is not working. Let me dig some more. I would image, it is the agent.js that is failing here. Since it should be the one handling the actual signout logic

@jfcherng
Copy link
Collaborator Author

jfcherng commented May 29, 2024

Mine just switched over to apps.json and now signout is not working. Let me dig some more. I would image, it is the agent.js that is failing here. Since it should be the one handling the actual signout logic

Yes, it's weird that Copilot.vim seems just calls the signOut command and that's all. github/copilot.vim@c79d711/autoload/copilot.vim#L630-L638

But since Copilot.vim intentionally disables the issue page on GitHub, I guess my report may not be seen by staff in Copilot's general discussion.

@jfcherng jfcherng merged commit 1252d23 into master May 29, 2024
2 checks passed
@jfcherng jfcherng deleted the fix/sign-out branch May 29, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't sign out
2 participants