fix: Edam Files format is incompatible with TerosHDL's file format #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edam's
File
field must contain thefile_type
in a format likevhdlSource-2008
.Latest TerosHDL's project structure changes have a different approach for version storage. It is done by storing a version information in a separate
file_version
field, whilefile_type
still used as a file type. For example:file_type
isvhdlSource
andfile_version
is2008
.So that change pass the file information structure to Edalize in a wrong format. That is cause of loosing version information.
To fix that, the file type and the file version must be combined back. At least, I guess it must be for
verilogSource-2005
andvhdlSource-2008
.However, I'm no sure what version Edam file assumes if
file_type
doesn't contain explicit version. So the fix is discussionable. Also, I didn't check other side effects of project structure change. This changes effectively fix recognition ofvhdlSource-2008
and, maybe,verilogSource-2005
.