Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce licenses #1140

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enforce licenses #1140

wants to merge 4 commits into from

Conversation

akomakom
Copy link
Contributor

@akomakom akomakom commented Apr 16, 2020 •
edited
Loading

  • core never enforced header licenses due to a pom error. Using new parent that enforces licenses.
  • All headers have been brought in sync using mvn license:format
  • Due to a change in license plugin configuration, a trailing blank line is removed from all files.
  • parent also adds spotbugs execution

@akomakom akomakom force-pushed the enforce-licenses branch 2 times, most recently from 0ef5feb to 383ca92 Compare April 16, 2020 21:53
@akomakom
Copy link
Contributor Author

@myronkscott I have these options:

  1. Disable spotbugs for now and deal with fixing violations in a separate PR
  2. Fix them in this PR

The downside of option 2 is that the diff is already overwhelming. But it's fine with me.

@myronkscott
Copy link
Member

Disable spot bugs for this repo. Too much legacy to deal with. I don’t think it is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myronkscott myronkscott Awaiting requested review from myronkscott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akomakom @myronkscott