Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for nested BKA MUL/PAN bundles in nested ZIP files #43

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

floeschau
Copy link
Collaborator

With this change, metadata from source products of the structure below is extracted correctly into a single STAC item (note the 3 layers of ZIP archives):

├── 925_bka_1028560.zip
│   ├── 525_bka_1028560.xml
│   ├── PREVIEW.jpg
│   └── PRODUCT.zip
│       ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR.zip
│       │   ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR.tif
│       │   ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR_bounds.dbf
│       │   ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR_bounds.prj
│       │   ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR_bounds.shp
│       │   ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR_bounds.shx
│       │   ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR_pasp-en.xml
│       │   ├── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR_preview.jgw
│       │   └── 4089411-0220-MUL-C-1-1-1139831-160712T150120-BR_preview.jpg
│       └── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR.zip
│           ├── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR.tif
│           ├── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR_bounds.dbf
│           ├── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR_bounds.prj
│           ├── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR_bounds.shp
│           ├── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR_bounds.shx
│           ├── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR_pasp-en.xml
│           ├── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR_preview.jgw
│           └── 4089411-0220-PAN-C-1-1-1139831-160712T150120-BR_preview.jpg
├── urn_ogc_def_EOP_NAS_NAS_1028560-icon.jpg
└── urn_ogc_def_EOP_NAS_NAS_1028560-preview.jpg

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d8f02a5) 53.31% compared to head (12162b5) 56.82%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    53.31%   56.82%   +3.51%     
===========================================
  Files          240      240              
  Lines        35145    35314     +169     
  Branches      3014     3045      +31     
===========================================
+ Hits         18738    20068    +1330     
+ Misses       16407    15246    -1161     
Flag Coverage Δ
unittests 56.82% <96.37%> (+3.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Model/Metadata/Saocom1/Saocom1MetadataExtractor.cs 94.63% <ø> (ø)
...rs.Data/Model/Metadata/Bka/BkaMetadataExtractor.cs 96.89% <96.37%> (+0.09%) ⬆️

... and 52 files with indirect coverage changes

@emmanuelmathot emmanuelmathot merged commit 48a7c66 into develop Feb 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants