Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix csv colorMap for map with offset values #33

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Fix csv colorMap for map with offset values #33

merged 5 commits into from
Jan 25, 2021

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Jan 12, 2021 •
edited
Loading

In v7 colorMap can be three things:

  • String, eg. 'red-black'
  • Array of strings, eg. ['red', 'black']
  • Array of objects with the properties 'color' and 'offset', eg. [{color: 'red', offset: 0}, ...].
    • v8 only supports array of strings, so 'offset' is discarded

This PR adds support for:

  • colorMap "array of objects with the properties 'color' and 'offset'"
  • colorPalette
  • colorBins
  • column name as title
  • column styles support
  • fix column type='hidden'

@nf-s nf-s mentioned this pull request Jan 12, 2021
Closed
@nf-s nf-s marked this pull request as draft January 13, 2021 02:19
@nf-s nf-s mentioned this pull request Jan 13, 2021
Closed
@nf-s nf-s marked this pull request as ready for review January 14, 2021 04:11
@nf-s nf-s changed the base branch from master to aremi-items January 25, 2021 06:25
@nf-s nf-s merged commit 607a81c into aremi-items Jan 25, 2021
@nf-s nf-s deleted the csv-colorbins branch January 25, 2021 06:25
@nf-s nf-s mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nf-s