Fetch xhr #49
Fetch xhr #49
Conversation
bring TerriaJS/cesium updates into my fork
…od that wants to handle it directly. changes made should only get used if called with Resource.fetchXHR
There was a problem hiding this comment.
Thank you for your pull request!
We use the terriajs branch of this repository rather than master for development (which we need to document better, so I will fix that shortly :) ). This uses a more up to date version of Cesium, so you shouldn't have to merge the changes in from there yourself.
Also, it looks like you might be using Prettier or some other formatter which is inconsistent with Cesium's formatting style. It makes the diff much bigger and harder for me to figure out which changes you've made so I can review them properly. For this repo, we use the formatting guidelines from upstream Cesium, which there are some info on here.
If you fix those things up, it'll make it easier for me to review your changes and give the PR the attention it deserves :)
|
will fix formatting on monday |
|
Closing since this is superseded by #51 |
based off the feedback from the last pull request for this purpose
adding the ability to return status and headers with a response body
in a manner that would not modify any requests not using this new method