Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itemProperties is not applied to groups inside a CkanCatalogGroup #1052

Closed
stevage opened this issue Nov 10, 2015 · 8 comments · Fixed by #6218
Closed

itemProperties is not applied to groups inside a CkanCatalogGroup #1052

stevage opened this issue Nov 10, 2015 · 8 comments · Fixed by #6218

Comments

@stevage
Copy link
Contributor

stevage commented Nov 10, 2015

When all the data for a map comes from one CKAN, it makes sense to have the CkanCatalogGroup open by default and immediately start populating. Requested for City of Sydney ESP.

@stevage stevage self-assigned this Nov 10, 2015
@kring
Copy link
Member

kring commented Nov 10, 2015

@stevage you should be able to stick isOpen: true in the init file and it will do as you've described. Is it not working?

@stevage
Copy link
Contributor Author

stevage commented Nov 10, 2015

@stevage
Copy link
Contributor Author

stevage commented Nov 10, 2015

It's not a particularly up to date TerriaJS, though - has this been implemented recently?

@stevage
Copy link
Contributor Author

stevage commented Nov 10, 2015

(Definitely doesn't work even on up to date TerriaJS)

@stevage
Copy link
Contributor Author

stevage commented Nov 10, 2015

Looks like the Ckan results fetch is being triggered, it's just not actually ending up with an open menu.

@tephenavies
Copy link
Member

The itemProperties property updates properties of data sources that belong the that top level group. In order to open subgroups of a top level group, a new property childGroupProperties could be added to the top level group. Including isOpen: true in the childGroupProperties would expand all second level groups of the specified top level group.

@stevage
Copy link
Contributor Author

stevage commented Nov 25, 2015

@steve9164 We actually already have itemProperties which pretty much behaves like that...except I think I tried it in this case and it didn't work.

@tephenavies
Copy link
Member

@stevage itemProperties at this point sometimes applies to subgroups and sometimes to data sources within a group. I was going to clear up these inconsistencies by changing itemProperties to only refer to data sources and add a childGroupProperties to refer to subgroups.

The reason that the isOpen: true in the itemProperties currently doesn't work for CKAN is that in CkanCatalogGroup.js, itemProperty is only applied to data sources and not to the subgroups.

@stevage stevage removed their assignment Dec 7, 2015
@stevage stevage added the T-Bug label Feb 25, 2016
@kring kring changed the title Support isOpen in CkanCatalogGroup itemProperties is not applied to groups inside a CkanCatalogGroup Feb 5, 2018
@kring kring removed the P-Sydney-ESP label Feb 5, 2018
@nf-s nf-s closed this as completed in #6218 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants