-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add itemProperties
, itemPropertiesByType
and itemPropertiesByIds
#6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reordered Stratum to reflect what we have today
… + use `definition` strata for dynamic group member creation
tephenavies
reviewed
Apr 4, 2022
nf-s
changed the title
Add
Add Apr 4, 2022
itemProperties
, itemPropertiesByType
and itemPropertiesById
itemProperties
, itemPropertiesByType
and itemPropertiesByIds
tephenavies
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good! I've wanted something like this for a while.
This was referenced Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
itemProperties
,itemPropertiesByType
anditemPropertiesByIds
Fixes #1052 #5631 #5155 #1408 TerriaJS/nationalmap#1129
itemProperties
,itemPropertiesByType
anditemPropertiesByIds
toGroupTraits
andReferenceTraits
.override
strataitemPropertiesByIds
,itemPropertiesByType
,itemProperties
.itemProperties
,itemPropertiesByType
oritemPropertiesByIds
- then child groups will have these values copied tounderride
when the parent group is loadedWebMapServiceCatalogGroup
) will create members and setdefinition
strata (instead ofunderride
)New docs
These are a bit rough
Background
For the SIP dataset styling issue (in NationalMap) - I’ve been looking into fleshing out
itemProperties
so I can attach custom styling to each dataset.The SIP datasets are harvested from CKAN (data.gov.au) - so we can’t use itemProperties in its current form.
Test me
A bunch of CSVs loaded from CKAN - with overridden styles
http://ci.terria.io/item-props/#clean&https://gist.githubusercontent.com/nf-s/67a545b72eef135a9d4903e2a65b9d9b/raw/02fcfcabfc37ad6eedb2908aa0c52ee39bcf6c0c/item-props-by-id.json&share=s-aAu23kmvBQxDNGwoVU3zQxjiGry
Example
https://gist.githubusercontent.com/nf-s/67a545b72eef135a9d4903e2a65b9d9b/raw/02fcfcabfc37ad6eedb2908aa0c52ee39bcf6c0c/item-props-by-id.json
Checklist
doc/
.