Skip to content

Improve naming of Url to CatalogItem #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2020
Merged

Improve naming of Url to CatalogItem #4282

merged 2 commits into from
May 7, 2020

Conversation

nf-s
Copy link
Member

@nf-s nf-s commented May 5, 2020 •
edited
Loading

What this PR does

I renamed createCatalogItemFromUrlReference to createUrlReferenceFromUrlReference in #4139

I am sorry.

I have now renamed createUrlReferenceFromUrlReference to createCatalogMemberFromUrlReference

I have also moved the mapping from url to catalog item type from createUrlReferenceFromUrl file to UrlReference and I have called it UrlToCatalogMemberMapping

@nf-s nf-s changed the title fix Nick's bad naming Improve naming of createCatalogItemFromUrlReference, UrlReference, and the whole Url to CatalogItem type mapping thing May 5, 2020
@nf-s nf-s changed the title Improve naming of createCatalogItemFromUrlReference, UrlReference, and the whole Url to CatalogItem type mapping thing Improve naming of Url to CatalogItem May 5, 2020
@nf-s nf-s merged commit 5c2a42d into mobx May 7, 2020
@nf-s nf-s deleted the mobx-fix-nicks-stupid-naming branch May 7, 2020 06:26
@soyarsauce
Copy link
Contributor

Was there a changelog update for this? @nf-s

@soyarsauce
Copy link
Contributor

I can't see one so if there wasn't just commit something onto mobx directly w/ the changeupdate

@nf-s
Copy link
Member Author

nf-s commented May 7, 2020

Sorry I forgot, I'll do that now

@nf-s
Copy link
Member Author

nf-s commented May 7, 2020

Done - d7be336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@soyarsauce soyarsauce soyarsauce approved these changes

@tephenavies tephenavies tephenavies approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-s @soyarsauce @tephenavies