Add refreshEnabled trait and AsyncMappableMixin to AutoRefreshMixin #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nf-s
commented
Jul 9, 2020
| @@ -33,6 +34,7 @@ class PollingTraits extends ModelTraits { | |||
| } | |||
|
|
|||
| export default class CsvCatalogItemTraits extends mixTraits( | |||
| AutoRefreshingTraits, | |||
There was a problem hiding this comment.
Maybe this shouldn't be here, as all AutoRefreshingTraits are computed values in CsvCatalogItem
…TerriaJS/terriajs into autorefreshmixin-refreshenabled
rowanwins
reviewed
Jul 13, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
refreshEnabledtrait andAsyncMappableMixintoAutoRefreshMixinThis adds a 'toggle' trait so the AutoRefreshMixin can be turned off or back on.
Example with 2 CSV catalog items: one with
refreshEnabled=trueand one withrefershEnabled=false:http://ci.terria.io/autorefreshmixin-refreshenabled/#clean&https://gist.githubusercontent.com/nf-s/7add30fc21d000e5e1710faf09e0dc4b/raw/1abf730796ef82d8c332d3aec7d7a2eec3db90d6/polling.json
Motivation
This is used in the
CatalogFunctionMixinandCatalogFuntionJobMixin- #4229For example - here https://github.com/TerriaJS/terriajs/blob/79d51860836270eff93eab6008a73298c81b689b/lib/ModelMixins/CatalogFunctionJobMixin.ts