Add preserveOrder trait on CatalogGroup #4809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
79 tasks
|
I don't think we should alphabetically order members by default - I think we should preserve order instead |
TODO:
|
|
Replaced by #6098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR ports the
preserveOrdertrait for theCatalogGroupmodel. I noticed it was responsible for many errors in the catalog converter.It's perhaps not completely ideal, in some regards it would be nice if this was somehow implemented on the
GroupMixinbut that seemed a somewhat more complicated task...If folks are happy with the approach I'll write a few tests, but I thought I'd whack this up for initial thoughts.
Checklist