Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge catalog groups with the same name/id into one group #4980

Merged
merged 5 commits into from
Dec 1, 2020

Conversation

reginapramesti
Copy link
Contributor

@reginapramesti reginapramesti commented Nov 10, 2020

What this PR does

Fixes #4938

Implement v7 feature that allows having multiple catalog groups with the same name but different members, to allow having different catalog json files with the same top level group name

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

Sorry, something went wrong.

Copy link
Member

@tephenavies tephenavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge @KeyboardSounds or @nf-s when tests pass (tests pass locally).

@KeyboardSounds KeyboardSounds merged commit 49a43a6 into next Dec 1, 2020
@KeyboardSounds KeyboardSounds deleted the allow-merging-catalog-groups branch December 1, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants