Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableMixin styles (display variables) use column title #5135

Merged
merged 5 commits into from
Jan 27, 2021
Merged

TableMixin styles (display variables) use column title #5135

merged 5 commits into from
Jan 27, 2021

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Jan 13, 2021 •
edited
Loading

TableMixin styles (display variables) use column title

If style.title is undefined, use column.title for display variable dropdown.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

@nf-s nf-s changed the base branch from master to next January 13, 2021 12:12
This was referenced Jan 13, 2021
Closed
Closed
KeyboardSounds
KeyboardSounds approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@KeyboardSounds KeyboardSounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from one tiny nitpick which you can ignore if you disagree.

@nf-s nf-s merged commit 1844de8 into next Jan 27, 2021
@nf-s nf-s deleted the tablemixin-style-coltitle branch January 27, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeyboardSounds KeyboardSounds KeyboardSounds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nf-s @KeyboardSounds