Add fallback for Color.fromCssColorString #5174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallback for Color.fromCssColorString
The type signature for
Color.fromCssColorString(col:string) => Color
is incorrect as it can return undefined.For example, this catalog has a CSV with an enum color map with an invalid CSS color:
When the catalog item is added to the workbench the map will crash.
This PR adds default colors for wherever Color.fromCssColorString is used.
I also deleted some old JS files:
Checklist