Misc AREMI fixes #5187
Merged
Misc AREMI fixes #5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tephenavies
reviewed
Jan 31, 2021
Comment on lines
90
to
101
| // Alises is a map from `key` (which exists in propertyData.properties) to some `aliasKey` which needs to resolve to `key` | ||
| // and Yes, this is awful, but not that much worse than what was done in V7 | ||
| let aliases = []; | ||
| if (TableMixin.isMixedInto(this.props.catalogItem)) { | ||
| aliases = this.props.catalogItem.columns | ||
| .filter(col => col.name && col.title && col.name !== col.title) | ||
| .map(col => [col.name, col.title]); | ||
| } | ||
| aliases.forEach(aliasMap => { | ||
| propertyData[aliasMap[0]] = propertyData[aliasMap[1]]; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Should aliasMap[1] keys be removed from propertyData? And is it possible or likely that an aliasMap[0] could also be an aliasMap[1] later in aliases and hence the key will be overwritten in propertyData?
There was a problem hiding this comment.
I think we need both in propertyData - as some feature templates use column name and others use column title (even if both are defined).
Overwriting aliases is definitely possible, but it seems unlikely someone would name a column.title after a different column.name. I have added this so at least we aren't overriding properties which are defined:
propertyData[aliasMap[0]] = propertyData[aliasMap[0]] ?? propertyData[aliasMap[1]];I have also shallow cloned propertyData so we aren't messing with feature.propertes|currentProperties|...
tephenavies
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc AREMI fixes
CkanCatalogGroup.groupBy = "none"membersTableMixinregion mapping feature props and make Long/Lat features use column titles (if it exists) to match v7 behaviour.FeatureInfoSection.jsx. In v7 - we used to add this to eachFeature-properties._terria_columnAliases = tableStructure.getColumnAliases()- which I think is worse...CkanItemReferencewms_layerpropertyArcGisMapServerCatalogGroupto usesublayerIds.wordBreak="break-all"fromBoxsurroundingDataPreviewDescriptionand other elements that didn't reverse thisChecklist