Config traits

[zoran995]

What this PR does

Fixes #
TerriaMap PR: TerriaJS/TerriaMap#557

Update TerriaJS config parameters to use traits system. Some of the parameters are renamed

• showWelcomeMessage and welcomeMessageVideo are now parameters on object welcomeMessage as show and video
• helpContent is now helpItems
• helpContentTerms are now helpTerms (they are not strictly related to helpContent)
• feedbackPreamble and feedbackMinLength are now parameters on object feedback as preamble and minLength
• brandBarElements, brandBarSmallElements, displayOneBrand are now parameters on object brandBar as elements, smallElements, displayOneBrand
• googleUrlShortenerKey is deprecated long time ago but still left as a config parameter
• disclaimer is not used anywhere so I added it to deprecated list
• globalDisclaimer is also not used anywhere - not sure if IT should be marked as deprecated as it is set from TerriaMap?

TODO

• Check if some conditions depend only on the existence of specific configParameter in case when it is not primitiveTrait, objectTrait will always be defined and that condition should be updated
• Convert deprecated options to the new ones - edit: added basic conversion, as I don't see that we really need anything on model level for now
• Documentation should generate automatically (as for catalog items) - Best to do this as a separate PR
• Introduce required option for trait system (at least for configuration if not doable for generic) - Probably best to do this as a separate PR (maybe target this one at first if this is not merged before)

p.s. this was much easier than initially expected

Checklist

• [ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist) - All existing test pass
• I've updated relevant documentation in doc/.
• I've updated CHANGES.md with what I changed.

[zoran995]

was getting type error

[zoran995]

This is ready for review, added a basic conversion so no breaking changes are introduced in patch or minor version.

[zoran995]

did another pass over this, also tried loading prod map-configs from https://github.com/TerriaJS/saas-catalogs-public, and no issue is raised to the user so I am pretty much confident that this can go without having to update the configs right away

[tephenavies]

Just dropping a comment here for a future full review: I think this should be:

Suggested change

	idProperty: "index"
	idProperty: "itemName",

though I haven't thought through the consequences of either idProperty choices.

[nf-s]

I think itemName is good - then makes it easy to remove specific default help items

[tephenavies]

Relating to https://github.com/TerriaJS/terriajs/pull/5918/files#r894124712. If using itemName as an id you could add:

static isRemoval(helpItem: HelpItemTraits) {
  // This condition looks sensible
  return helpItem.markdownText === null && helpItem.trainerItems === null;
}

And then you could have default helpItems in terriajs that get overriden/removed in TerriaMap config using the strata system, I think. I have to play around with this branch sometime. And default help items in terriajs means translation support!