Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shebang replacement #467

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Shebang replacement #467

merged 1 commit into from
Feb 20, 2024

Conversation

GregWhiteyBialas
Copy link
Contributor

This PR will fix this issue.

Pretty good explanation of root of this issue is here especially this comment.

Rationale behind deleting shebang instead of changing it to #!/usr/bin/python:

  • it will default to #!/usr/bin/python anyway.
  • module files aren't executed so no shebang isn't needed, and modules should be treated more like python libraries not executables.
  • if any change to interpreter is needed it should be done by using ansible_python_interpreter variable, which this PR made possible.

Any contribution and comment is welcomed.

@TerryHowe
Copy link
Owner

I think the idea was to change the shebang, not remove it.

@GregWhiteyBialas
Copy link
Contributor Author

GregWhiteyBialas commented Feb 20, 2024

Ok, I changed shebang instead of removing it.

(edit: typo)

@GregWhiteyBialas GregWhiteyBialas changed the title Shebang remove Shebang replacement Feb 20, 2024
@GregWhiteyBialas
Copy link
Contributor Author

I have also renamed this PR so it better reflects changes that are made.

@TerryHowe TerryHowe merged commit 2b4b985 into TerryHowe:main Feb 20, 2024
3 checks passed
@nyetwurk
Copy link

Hey all, this breaks folks who use python venv

@nyetwurk
Copy link

This is very broken, as there is no way to install hvac without pip on alpine

https://hvac.readthedocs.io/en/stable/overview.html#installation

There does not seem to be an py3-hvac alpine package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants