Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Improve enzyme management #586

Merged
merged 7 commits into from
Oct 9, 2020
Merged

Improve enzyme management #586

merged 7 commits into from
Oct 9, 2020

Conversation

tnrich
Copy link
Contributor

@tnrich tnrich commented Mar 3, 2020

Connects #561

@cypress
Copy link

cypress bot commented Mar 4, 2020



Test summary

141 12 0 0


Run details

Project openVectorEditor
Status Failed
Commit cd10022
Started Oct 7, 2020 9:10 PM
Ended Oct 7, 2020 9:18 PM
Duration 07:58 💡
OS Linux Ubuntu - 16.04
Browser Electron 83

View run in Cypress Dashboard ➡️


Failures

editor.spec.js Failed
1 editor > should handle enabling external labels and then only showing labels that don't fit
2 editor > should handle adjusting label line intensity.
3 editor > should handle adjusting circular map label size.
clickDragCaretAndSelectionLogic.spec.js Failed
1 clickDragCaretAndSelectionLogic > should not allow origin spanning drags if linear (circular view drag)
2 clickDragCaretAndSelectionLogic > should not allow origin spanning click if linear (circular view click with previous selection present)
3 clickDragCaretAndSelectionLogic > should handle dragging correctly
toolbar.spec.js Failed
1 toolbar > can search the cutsites and not find any and have the add additional enzymes option pop up
2 toolbar > can open the cutsite dropdown and add an additional enzyme
addYourOwnEnzyme.spec.js Failed
1 addAdditionalEnzymes > can open the add additional enzymes dialog from the Tools > Manage Enzymes and add a custom user enzyme
2 addAdditionalEnzymes > can open the add additional enzymers dialog from the Tools > Manage Enzymes and add an additional enzyme
This comment includes only the first 10 test failures. See all 12 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

…vidual enzymes; starting to add user created enzyme groups to cutsite filter
@tnrich tnrich changed the title merging in master Improve enzyme management Mar 24, 2020
@codecov-io
Copy link

Codecov Report

Merging #586 into master will decrease coverage by 0.43%.
The diff coverage is 77.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   71.21%   70.78%   -0.44%     
==========================================
  Files         227      228       +1     
  Lines        8164     8225      +61     
  Branches     2737     2736       -1     
==========================================
+ Hits         5814     5822       +8     
- Misses       2089     2137      +48     
- Partials      261      266       +5     
Impacted Files Coverage Δ
src/MenuBar/defaultConfig.js 100.00% <ø> (ø)
src/MenuBar/viewSubmenu.js 20.00% <ø> (ø)
src/ToolBar/alignmentTool.js 6.42% <0.00%> (ø)
src/ToolBar/cutsiteTool.js 63.15% <0.00%> (-11.85%) ⬇️
src/helperComponents/MergeFeaturesDialog/index.js 0.00% <0.00%> (ø)
...erComponents/PropertiesDialog/CutsiteProperties.js 82.50% <ø> (-2.50%) ⬇️
...helperComponents/PropertiesDialog/OrfProperties.js 76.19% <ø> (ø)
src/index.js 100.00% <ø> (ø)
src/redux/restrictionEnzymes.js 70.00% <ø> (-14.62%) ⬇️
src/selectors/cutsitesSelector.js 100.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4d145...cd10022. Read the comment docs.

@tnrich tnrich merged commit 486f3f1 into master Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants