Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Fixed Circular view title rotate issue. #777

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

XingGao-PKI
Copy link
Contributor

@XingGao-PKI XingGao-PKI commented Oct 13, 2021

@tnrich, We found that after the pre change, the title rotates with the Circular View.
Try to rotate it back here.

@cypress
Copy link

cypress bot commented Oct 13, 2021



Test summary

200 1 0 0


Run details

Project openVectorEditor
Status Failed
Commit 77a8ed6 ℹ️
Started Oct 13, 2021 7:39 AM
Ended Oct 13, 2021 7:51 AM
Duration 11:47 💡
OS Linux Ubuntu - 20.04
Browser Electron 91

View run in Cypress Dashboard ➡️


Failures

cypress/integration/menuBar.spec.js Failed
1 menuBar > should not be able to select a range in a length 0 sequence

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

Codecov Report

Merging #777 (1dd5d65) into master (b1f9f8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   72.96%   72.96%           
=======================================
  Files         243      243           
  Lines        9292     9292           
  Branches     3131     3131           
=======================================
  Hits         6780     6780           
  Misses       2219     2219           
  Partials      293      293           
Impacted Files Coverage Δ
src/CircularView/index.js 94.96% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f9f8c...1dd5d65. Read the comment docs.

Copy link
Contributor

@tnrich tnrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks

@tnrich tnrich merged commit 7134b31 into TeselaGen:master Oct 13, 2021
@tnrich
Copy link
Contributor

tnrich commented Oct 13, 2021

Released in open-vector-editor@16.3.43

@XingGao-PKI XingGao-PKI deleted the fixRotate branch October 14, 2021 01:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants