-
Notifications
You must be signed in to change notification settings - Fork 71
Fixed linearView start and end Axis text position #781
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Hey @XingGao-PKI I think I'm in favor of this change in general. Can you please fix the tests that are now failing due to this change? You'll probably need to adjust the selections slightly. Thanks! |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
- Coverage 73.02% 73.02% -0.01%
==========================================
Files 244 245 +1
Lines 9312 9334 +22
Branches 3137 3145 +8
==========================================
+ Hits 6800 6816 +16
- Misses 2219 2225 +6
Partials 293 293
Continue to review full report at Codecov.
|
@XingGao-PKI is this one ready to go or are you still cranking on it? |
@tnrich, ready to go, the failing test is an unexpected accident |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @XingGao-PKI !
Publishing this update in open-vector-editor@16.4.5 |
Make the linearView text showing start and end Axis text more reasonable