Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Fixed linearView start and end Axis text position #781

Merged
merged 4 commits into from
Oct 24, 2021

Conversation

XingGao-PKI
Copy link
Contributor

@XingGao-PKI XingGao-PKI commented Oct 20, 2021

Make the linearView text showing start and end Axis text more reasonable
Screen Shot 2021-10-20 at 9 05 40 AM

@cypress
Copy link

cypress bot commented Oct 20, 2021



Test summary

202 1 0 0


Run details

Project openVectorEditor
Status Failed
Commit d8a3067 ℹ️
Started Oct 21, 2021 5:20 AM
Ended Oct 21, 2021 5:34 AM
Duration 14:03 💡
OS Linux Ubuntu - 20.04
Browser Electron 91

View run in Cypress Dashboard ➡️


Failures

cypress/integration/import.spec.js Failed
1 import > importing multiple files should pop up a dialog to allow users to choose which sequence they'd like to focus on

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tnrich
Copy link
Contributor

tnrich commented Oct 20, 2021

Hey @XingGao-PKI I think I'm in favor of this change in general. Can you please fix the tests that are now failing due to this change? You'll probably need to adjust the selections slightly. Thanks!

@cypress
Copy link

cypress bot commented Oct 21, 2021



Test summary

3 0 0 0


Run details

Project openVectorEditor
Status Passed
Commit bda6f19
Started Oct 21, 2021 6:02 AM
Ended Oct 21, 2021 6:03 AM
Duration 00:17 💡
OS Mac 20.6.0
Browser Electron 91

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #781 (bda6f19) into master (cf6185d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   73.02%   73.02%   -0.01%     
==========================================
  Files         244      245       +1     
  Lines        9312     9334      +22     
  Branches     3137     3145       +8     
==========================================
+ Hits         6800     6816      +16     
- Misses       2219     2225       +6     
  Partials      293      293              
Impacted Files Coverage Δ
src/LinearView/index.js 91.11% <100.00%> (ø)
src/RowItem/Axis.js 100.00% <100.00%> (ø)
src/RowItem/index.js 74.70% <100.00%> (+0.14%) ⬆️
...erComponents/MultipleSeqsDetectedOnImportDialog.js 68.75% <0.00%> (-31.25%) ⬇️
src/RowItem/Translations/Translation.js 88.88% <0.00%> (-0.70%) ⬇️
src/RowItem/Translations/index.js 100.00% <0.00%> (ø)
src/RowItem/Translations/AASliver.js 91.30% <0.00%> (ø)
src/utils/useAAColorType.js 100.00% <0.00%> (ø)
src/commands/index.js 74.57% <0.00%> (+0.04%) ⬆️
src/MenuBar/viewSubmenu.js 85.00% <0.00%> (+12.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6185d...bda6f19. Read the comment docs.

@tnrich
Copy link
Contributor

tnrich commented Oct 21, 2021

@XingGao-PKI is this one ready to go or are you still cranking on it?

@XingGao-PKI
Copy link
Contributor Author

@tnrich, ready to go, the failing test is an unexpected accident

Copy link
Contributor

@tnrich tnrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @XingGao-PKI !

@tnrich tnrich merged commit 6b1f799 into TeselaGen:master Oct 24, 2021
@tnrich
Copy link
Contributor

tnrich commented Oct 24, 2021

Publishing this update in open-vector-editor@16.4.5

@XingGao-PKI XingGao-PKI deleted the CLN-32135-master branch August 16, 2023 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants