Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

ssDNA should not show reverseSequence automaticlly #898

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

XingGao-PKI
Copy link
Contributor

@XingGao-PKI XingGao-PKI commented Jun 28, 2023

With this change and TeselaGen/tg-oss#1
Reversed sequence does not show when drag a ss-DNA file in.
image

@@ -13,6 +13,9 @@ class GenbankView extends React.Component {
state = {
fileTypeToView: "genbank"
};

select = () => this._input?.select();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change fixed the Genbank View selection and also the console warning in dev tool.

@cypress
Copy link

cypress bot commented Jun 28, 2023

4 failed tests on run #1652 ↗︎

4 266 1 0 Flakiness 0

Details:

Merge 1a466f5 into 7fe072d...
Project: openVectorEditor Commit: dad24945cc ℹ️
Status: Failed Duration: 11:49 💡
Started: Jun 28, 2023 6:05 AM Ended: Jun 28, 2023 6:16 AM
Failed  menuBar.spec.js • 2 failed tests

View Output Video

Test Artifacts
menuBar > should be able to use the search/shortcut bar to translate the sequence Output Screenshots
menuBar > should be able to change the amino acid color (by hydrophobicity or by family) Output Screenshots
Failed  enzymeManager.spec.js • 1 failed test

View Output Video

Test Artifacts
enzymeManager > enzymes not shown by default should show up when added to a group (and hiding an enzyme that is shown in a group should work) Output Screenshots
Failed  umdDemo.spec.js • 1 failed test

View Output Video

Test Artifacts
umd demo > the umd demo should load and show the editors Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@XingGao-PKI
Copy link
Contributor Author

@tnrich could you check this and TeselaGen/tg-oss#1.
Any concerns you can comment here.

@tnrich tnrich merged commit b951fcc into TeselaGen:master Jul 8, 2023
0 of 3 checks passed
tnrich added a commit to TeselaGen/tg-oss that referenced this pull request Jul 8, 2023
@tnrich
Copy link
Contributor

tnrich commented Jul 12, 2023

@XingGao-PKI it looks like adding annotationVisibilityUpdated to the isAlreadySpecialEditor causes translations to not show up on the default sequence and broke a few tests

This code in particular:

image

Broke these tests -
image

https://cloud.cypress.io/projects/mp89gp/runs/1654/overview?roarHideRunsWithDiffGroupsAndTags=1

I'm going to revert that part of your change from ove. Can you explain why you added that code?

tnrich added a commit that referenced this pull request Jul 12, 2023
@XingGao-PKI
Copy link
Contributor Author

if you init the editor with a SS-DNA, it will be fine, but if you pull one ss-DNA to ds-DNA borad, we need to update the reverseSequence. it's OK you reverted this part, I will check if we have another way to change it.

@XingGao-PKI XingGao-PKI deleted the supportSSDNA branch August 16, 2023 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants