Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

use user defined annotationVisibility props at the first place #909

Closed
wants to merge 1 commit into from

Conversation

sunm19810-pki
Copy link
Contributor

* use user defined annotationVisibility props firstly

* replace 'T' with 'U'

* more changes
@sunm19810-pki
Copy link
Contributor Author

Hi @tnrich, I added some code to make the OVE annotationVisibility props work. Please help review, thanks.

@sunm19810-pki sunm19810-pki marked this pull request as ready for review July 24, 2023 01:27
@cypress
Copy link

cypress bot commented Jul 24, 2023

5 failed tests on run #1705 ↗︎

5 265 1 0 Flakiness 0

Details:

CLN-54033: use user defined annotationVisibility props firstly (#15)
Project: openVectorEditor Commit: 61ffde0087
Status: Failed Duration: 12:23 💡
Started: Jul 24, 2023 1:20 AM Ended: Jul 24, 2023 1:32 AM
Failed  editing.spec.js • 1 failed test

View Output Video

Test Artifacts
editing > should be able to insert data around the origin correctly - new sequence should be inserted after the origin Output Screenshots
Failed  autoAnnotate.spec.js • 1 failed test

View Output Video

Test Artifacts
autoAnnotate > auto annotating parts should work when the csv file has a 'type' column Output Screenshots
Failed  labels.spec.js • 1 failed test

View Output Video

Test Artifacts
label tests > should show/hide a checkmark when toggling feature label visibility Output Screenshots
Failed  rowViewSpacing.spec.js • 1 failed test

View Output Video

Test Artifacts
rowViewSpacing.spec > should be able to modify the spacing of the row view Output Screenshots
Failed  umdDemo.spec.js • 1 failed test

View Output Video

Test Artifacts
umd demo > the umd demo should load and show the editors Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov-commenter
Copy link

Codecov Report

Merging #909 (61ffde0) into master (d216b55) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   74.77%   74.64%   -0.14%     
==========================================
  Files         291      291              
  Lines       11295    11296       +1     
  Branches     4067     4076       +9     
==========================================
- Hits         8446     8432      -14     
- Misses       2496     2505       +9     
- Partials      353      359       +6     
Impacted Files Coverage Δ
src/RowView/index.js 89.40% <ø> (ø)
src/RowItem/index.js 78.14% <100.00%> (ø)
src/updateEditor.js 92.30% <100.00%> (+0.20%) ⬆️

... and 11 files with indirect coverage changes

@cypress
Copy link

cypress bot commented Jul 24, 2023

3 failed tests on run #1706 ↗︎

3 267 1 0 Flakiness 0

Details:

Merge 61ffde0 into d216b55...
Project: openVectorEditor Commit: b6cec43dc9 ℹ️
Status: Failed Duration: 12:25 💡
Started: Jul 24, 2023 1:27 AM Ended: Jul 24, 2023 1:39 AM
Failed  menuBar.spec.js • 1 failed test

View Output Video

Test Artifacts
menuBar > should be able to use the search/shortcut bar to translate the sequence Output Screenshots
Failed  primers.spec.js • 1 failed test

View Output Video

Test Artifacts
primers.spec > should be able to create a primer when no range is selected Output Screenshots
Failed  umdDemo.spec.js • 1 failed test

View Output Video

Test Artifacts
umd demo > the umd demo should load and show the editors Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sunm19810-pki
Copy link
Contributor Author

close as another in tg-oss/ove has merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants