-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ove and ui imports for vitest #25
Conversation
I also think you can put a deprecation on the https://www.npmjs.com/package/open-vector-editor and archive https://github.com/TeselaGen/openVectorEditor so we would immediately know next time when we perform dependency install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Hi @tnrich, I realized there are some additional issue and the tests are not passing. |
|
@smeng9 whoops, yeah looks like I only published ove, re-publishing both ui and ove now |
Also need to merge #26 to fix the file type used by web pack bundler |
All vitest passing in the example-demos/oveViteDemo now. Thanks! |
Hi @tnrich, we just noticed the https://github.com/TeselaGen/openVectorEditor gets moved to here.
We are trying to switch to the
@teselagen/ove
with our current build system and expecting to be simple name replacements but we found some issues with our testing.As a follow up of #13 and #16 , We noticed the exports needs to be done correctly with the correct format in order to be used in vitest. I changed the file name format in
vite.react.config.ts
and updated allpackage.json
to use the updated files. Somepackage.json
not exporting the files causing tests to fail.I have also updated your example to demonstrate vitest. We need to add
vitest
dependency, updatevite.config.js
configs, fix thetest.jsx
file extension, and update the test cases.If you publish a new versions of ove and ui, and bump the internal ove's dependency on ui with this merge request, the test cases will probably pass. For now it throws various errors complaining package exports are not setup correctly.