Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the ORF start codons label for RNA sequence #27

Merged
merged 1 commit into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/ove/cypress/e2e/orfs.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ describe("orfs", function () {
).should("exist");
});

it("'Use GUG And CUG As Start Codons' should show for RNA sequence", function () {
cy.visit("");
cy.get(`[data-test="moleculeType"]`).select("RNA");
cy.contains(".tg-menu-bar button", "View").click();
cy.contains(".bp3-menu-item:contains(7)", "ORFs").click();
cy.get(
".bp3-menu-item:contains(Use GUG And CUG As Start Codons) .bp3-icon-blank"
).should("exist");
});

it("ORFs should have Size AA equals (sequence size / 3 - 1)", function () {
cy.visit("");
cy.get(".veTabProperties").click();
Expand Down
5 changes: 4 additions & 1 deletion packages/ove/src/commands/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,10 @@ const editCommandDefs = {
useGtgAndCtgAsStartCodons: {
isHidden: isProtein,

name: "Use GTG And CTG As Start Codons",
name: props =>
isRna(props)
? "Use GUG And CUG As Start Codons"
: "Use GTG And CTG As Start Codons",
isActive: props => props.useAdditionalOrfStartCodons,
handler: props => props.useAdditionalOrfStartCodonsToggle()
},
Expand Down