Feature/bootstrap v5 #431
Draft
Feature/bootstrap v5 #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pe5h4
reviewed
Aug 7, 2023
| @@ -662,7 +662,7 @@ function ConfigSection(props) { | |||
| </div> | |||
| </Col> | |||
| </Row> | |||
| <FormGroup tag="fieldset" disabled={props.isSubmitting}> | |||
There was a problem hiding this comment.
@petrKavulok Why? I thought that <FormGroup> is a reactstrap tag, or were there any clashes with bootstrap5?
There was a problem hiding this comment.
Hi, it <FormGroup> is using Bootstraps class names and respective styling. Form specific layout classes were dropped in B5.
There was a problem hiding this comment.
Yes, but we are using reactstrap component here. And it is still present in reactstrap v9, which should be fully compatible with bootstrap v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.