Refactor/locales #432
Merged
Refactor/locales #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pe5h4
requested changes
Jun 30, 2023
There was a problem hiding this comment.
@queuing4oranges Ok, this looks good - dont forget to update also locales in demo app and add the changelog. Btw. the videos can be displayed because of corrupted content :)
|
replacing locales in asab-webui when locales load normally: demo-locales-correct.mp4when locales file is corrupted: demo-locales-corrupted.mp4hope the video works! |
Pe5h4
requested changes
Jul 3, 2023
src/components/Pagination.js
Outdated
| @@ -162,7 +162,8 @@ export default function ({ currentPage, setPage, lastPage, style }) { | |||
| </Dropdown> | |||
|
|
|||
| <div className="mr-2"> | |||
| {pages && (pages.length > 1) ? t('Pages', {pages: (lastPage == 0) ? 1 : lastPage}) : t('Page', {pages: (lastPage == 0) ? 1 : lastPage})} | |||
| {pages && (pages.length > 1) ? (`${t("of")} ${pages.length} ${t("Pages")}`) : | |||
| (`${t("of")} ${pages.length} ${t("Page")}`)} | |||
There was a problem hiding this comment.
@queuing4oranges Here I believe we want to have sometjing like:
{pages && (pages.length > 1) ? (`${t("of")} ${(lastPage == 0) ? 1 : lastPage} ${t("Pages")}`) : (`${t("of")} ${(lastPage == 0) ? 1 : lastPage} ${t("Page")}`)}
Pe5h4
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- when locales is loaded normally:
Kazam_screencast_00000.mp4
-- when the locales file is corrupted:
Kazam_screencast_00001.mp4